Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Refactor SubDao #219

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Refactor SubDao #219

merged 6 commits into from
Jul 24, 2023

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Jul 21, 2023

Explanation of the solution

  • missing validation
  • use Validator library for address validation
  • inherit ISubDao and fixes issues
  • minor refactors

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

@0xNeshi 0xNeshi added bug Something isn't working enhancement New feature or request labels Jul 21, 2023
@0xNeshi 0xNeshi self-assigned this Jul 21, 2023
@stevieraykatz stevieraykatz merged commit 163c087 into master Jul 24, 2023
1 check passed
@stevieraykatz stevieraykatz deleted the fix-subdao branch July 24, 2023 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@0xNeshi 0xNeshi

Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Angel Protocol dApp
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNeshi @stevieraykatz